-
Notifications
You must be signed in to change notification settings - Fork 286
docs: Update GMK resource examples now that Clusters and Topic resources are GA #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update GMK resource examples now that Clusters and Topic resources are GA #759
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
|
This may need (but I might not be able to successfully trigger this). /gcbrun |
johndee7310
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ship it for GA
This isn't being specifically created in the sample, but I'm not sure if it should exist in the project. You could either use the resource to create the subnetwork specifically, or use the data resource to pull the existing information (https://registry.terraform.io/providers/hashicorp/google/latest/docs/data-sources/compute_subnetwork). I'll /gcbrun it again to confirm it's not a temporary issue (previous issues were "internal errors", this is something specific) |
|
"default" subnetworks should exist in the project as long as the compute API is enabled. But I checked and the project with project number "261919062524" is being deleted or already has been deleted. |
|
I'm confused, why would the CI tests be on a deleted project? Or maybe the project was deleted after the tests were run, which is more likely. I'll look into using the subnet terraform resource in my sample. |
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
|
The tests should be running, now that I've updated the Cluster and Topic samples to make their own subnets with the |
|
Please let me know if there's anything else that I can do! |
|
Hi, I'm not able to see what went wrong in the latest CI test. Could someone give me some insights so I can try and fix the errors? |
|
@glasnt My team would like to include the project field on the |
…ces are GA (terraform-google-modules#759) * remove google beta * Setup subnetwork in sample * Setup subnetwork in topic sample * Add project identifier line to cluster and topic samples * Add project id line to clusters and topics with comment --------- Co-authored-by: Katie McLaughlin <[email protected]>
Description
GMK Clusters and Topics are getting promoted to GA after the submission of GoogleCloudPlatform/magic-modules#12264. We need to update our public documentation to use our GA resources instead of the google-beta ones. Issue: https://b.corp.google.com/issues/377724373
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/managed-service-for-apache-kafka/docs/create-cluster#create
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review